Fix Embed Edit, include src and dest, include snr#20
Merged
Conversation
Skordy
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issues with traceroute embeds failing to edit or append when replies are received, and greatly enhances the information displayed in the route path.
Changes
discord.Embed.from_dict()with a much safer.copy()method when duplicating the original embed. This preventsTypeErrorcrashes that were occurring during payload conversions. Additionally, catching a genericExceptionensures the bot will always gracefully fall back to posting a new message if the edit fails for any reason.RouteDiscoverypayload only tracks intermediary nodes. Added logic to correctly prepend the origin and append the destination to the traceroute path so the full route is visible.snr_towardsarray from theRouteDiscoverypayload. If the SNR data matches the forward path, the route is now formatted to show the signal-to-noise ratio at each hop (e.g.,NOD1 --(-2.5)→ NOD2 --(3.2)→ NOD3).Testing