New command for changing signups name#28
Merged
3Mydlo3 merged 3 commits intoArmaForces:masterfrom Jan 6, 2021
Merged
Conversation
Member
|
Wouldn't it be better to just change channel name and edit main mission description embed? Main mission embed edition should be fairly easy as it's already done when changing description or mission date. |
Contributor
Author
|
Check new commit. |
veteran29
reviewed
Jan 6, 2021
3Mydlo3
approved these changes
Jan 6, 2021
Member
3Mydlo3
left a comment
3Mydlo3
left a comment
There was a problem hiding this comment.
Nice small feature which being unavailable was very irritating.
| [ContextDMOrChannel] | ||
| public async Task MissionName([Remainder] string newTitle) | ||
| { | ||
| var signups = _map.GetService<SignupsData>(); |
Member
There was a problem hiding this comment.
Please use the SignupsData property instead of getting the service from provider.
Removed unnecessary variable and getting the service from provider.
3Mydlo3
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added command. Function active after choosing mission to edit. Then it basically creates new signups and deletes the old one without mentioning everyone.