Conversation
- Refactor `AgentViewMessages.displayMessage` to accept `shouldScroll` flag - Update `SessionUICallbacks` to support `shouldScroll` and `scrollToBottom` - Refactor `loadSessionHistory` to use sequential rendering with `shouldScroll: false` to prevent layout thrashing - Call `scrollToBottom` once after all messages are rendered Co-authored-by: ArnBdev <207385326+ArnBdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Optimized the rendering of chat history by preventing automatic scrolling after each message render.
🎯 Why: Loading a chat session with many messages caused layout thrashing (repeated read/write of
scrollTop), slowing down the UI.📊 Impact: Eliminates N-1 forced reflows during session load, where N is the number of messages. The UI now updates layout once at the end.
🔬 Measurement: Verify by loading a long chat session and observing the absence of "jank" or layout shifts during loading. Code review confirmed sequential rendering is necessary for correctness, so parallelization was reverted in favor of this safe optimization.
PR created automatically by Jules for task 9285768785649520587 started by @ArnBdev