Skip to content

Promote develop to main: ESLint/CodeQL quality alignment#34

Closed
ZappoMan wants to merge 1 commit into
mainfrom
develop
Closed

Promote develop to main: ESLint/CodeQL quality alignment#34
ZappoMan wants to merge 1 commit into
mainfrom
develop

Conversation

@ZappoMan
Copy link
Copy Markdown
Contributor

@ZappoMan ZappoMan commented Apr 25, 2026

Summary

Promotion PR from develop into main.

This promotes the CodeQL/code-quality alignment work that landed in develop, including:

  • expanded ESLint coverage across repo paths that were previously outside local lint
  • CI path-filter updates so script-only changes still run the Test workflow
  • follow-up doc fix aligning phasePrereqs JSDoc param names with the function signature

Included changes

  • Expand ESLint coverage and fix CodeQL-aligned quality issues (#33)
  • docs(setup): align phasePrereqs JSDoc @param with signature

Validation

  • Branch promotion from develop to main
  • CI checks on this PR

Merge strategy

This PR targets main. Use Create a merge commit (not squash merge).

* fixing CodeQL quality issues
* docs(setup): align phasePrereqs JSDoc @param with signature
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Merge Strategy Reminder

This PR targets the main branch. When merging, please use:

"Create a merge commit" (NOT squash merge)

Using "Squash and merge" on PRs targeting main can cause merge conflicts when merging developmain later.

See ARCHITECTURE.md for details.


Updated at: April 25, 2026 at 12:04 PM PDT

@ZappoMan ZappoMan changed the title Expand ESLint coverage and fix CodeQL-aligned quality issues (#33) Promote develop to main: ESLint/CodeQL quality alignment Apr 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CI Coverage & Test Summary

Metric Coverage Covered / Total
Statements 91.53% 5445 / 5949
Branches 80.62% 749 / 929
Functions 75.16% 115 / 153
Lines 89.44% 5321 / 5949

Suites: 33 passed, 0 failed (33 total) · Tests: 369 passed, 0 failed (397 total)

✅ All reported test suites passed.

Coverage artifacts: coverage-summary, coverage-packages.


Updated at: April 25, 2026 at 12:08 PM PDT

@ZappoMan ZappoMan closed this Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant