Skip to content

Promote develop to main: quality alignment and follow-up fixes#36

Merged
ZappoMan merged 2 commits into
mainfrom
develop
Apr 25, 2026
Merged

Promote develop to main: quality alignment and follow-up fixes#36
ZappoMan merged 2 commits into
mainfrom
develop

Conversation

@ZappoMan
Copy link
Copy Markdown
Contributor

@ZappoMan ZappoMan commented Apr 25, 2026

Summary

This is the actual promotion PR from develop to main.

It promotes the ESLint/CodeQL quality-alignment work and the immediate cleanup follow-up that landed on develop.

Included in this promotion

  • #33 — Expand ESLint coverage and fix CodeQL-aligned quality issues
  • #35 — Follow-up cleanup for the quality alignment changes

Highlights

  • Expanded lint coverage to repo areas previously outside local lint (scripts/, tests/, packages/shared-tests/, packages/test-utils/src/, apps/mobile/__tests__/).
  • Updated CI PR path filters so script-only/config-only changes still run the Test workflow.
  • Included follow-up quality fixes (test cleanup/order fix, simplified guard logic, env access consistency), plus the phasePrereqs JSDoc param-name alignment fix.

Validation

  • npm run lint
  • npm run lint:strict
  • CI checks for this promotion PR

Merge strategy

This PR targets main. Use Create a merge commit (not squash merge).

* fixing CodeQL quality issues
* docs(setup): align phasePrereqs JSDoc @param with signature
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Merge Strategy Reminder

This PR targets the main branch. When merging, please use:

"Create a merge commit" (NOT squash merge)

Using "Squash and merge" on PRs targeting main can cause merge conflicts when merging developmain later.

See ARCHITECTURE.md for details.


Updated at: April 25, 2026 at 12:25 PM PDT

@ZappoMan ZappoMan changed the title promote develop to main Promote develop to main: quality alignment and follow-up fixes Apr 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CI Coverage & Test Summary

Metric Coverage Covered / Total
Statements 91.53% 5445 / 5949
Branches 80.62% 749 / 929
Functions 75.16% 115 / 153
Lines 89.44% 5321 / 5949

Suites: 33 passed, 0 failed (33 total) · Tests: 369 passed, 0 failed (397 total)

✅ All reported test suites passed.

Coverage artifacts: coverage-summary, coverage-packages.


Updated at: April 25, 2026 at 12:29 PM PDT

@ZappoMan ZappoMan merged commit 83c0e73 into main Apr 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant