Skip to content

feat: DISABLE_SKILLS experiment toggle + tool arg schema improvements#444

Draft
isiddharthsingh wants to merge 3 commits into
sms10221/dev-rca-rigidity-prompt-fixesfrom
sms10221/dev-disable-skills-toggle
Draft

feat: DISABLE_SKILLS experiment toggle + tool arg schema improvements#444
isiddharthsingh wants to merge 3 commits into
sms10221/dev-rca-rigidity-prompt-fixesfrom
sms10221/dev-disable-skills-toggle

Conversation

@isiddharthsingh
Copy link
Copy Markdown
Contributor

Summary

  • Adds DISABLE_SKILLS env-var toggle that bypasses integration skill markdown and unregisters the load_skill LLM tool, so the agent can be A/B tested relying purely on tool descriptions.
  • Adds Pydantic args schemas (CloudExecArgs, IacToolArgs, TerminalExecArgs, AnalyzeZipArgs, OnPremKubectlArgs) so the LLM sees enum hints and per-field descriptions in the tool JSON schema. Adds a list_onprem_clusters discovery tool so the agent can find cluster IDs without skill guidance.
  • Gate is scoped narrowly: only the interactive_load_skill segment + SkillRegistry integration methods short-circuit when the flag is on; identity, security, behavioral_rules, RCA scaffolding, and core prompts keep loading.
  • Env var wired through docker-compose.yaml, docker-compose.prod-local.yml, docker-compose.airtight.yml, deploy/helm/aurora/values.yaml, and .env.example.

Test plan

  • 33/33 pytest cases pass (tests/experiment/test_disable_skills.py)
  • Live RCA run with flag on completed end-to-end; system prompt verified to retain identity/security/RCA scaffolding while integration-index and load_skill directive are absent
  • list_onprem_clusters returns the status:ok|error envelope; verified the error path for unresolvable users
  • Cache key invalidates on flag toggle; verified load_skill tool is unregistered when the flag is on

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1ba1cb5b-424d-4cc6-9825-cb8fd2151e29

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sms10221/dev-disable-skills-toggle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant