Skip to content

fix: ID-3404: JOGL renderer and off-screen view do not dispose all resources properly#18

Merged
meinders merged 11 commits into
masterfrom
ID-3404
Apr 22, 2026
Merged

fix: ID-3404: JOGL renderer and off-screen view do not dispose all resources properly#18
meinders merged 11 commits into
masterfrom
ID-3404

Conversation

@meinders

Copy link
Copy Markdown
Member

Several issues are fixed that greatly reduce the amount of resources leaked during off-screen rendering:

  • JOGLOffscreenView doesn't dispose JOGLRenderer at all
  • JOGLRenderer does not dispose ShadowMap
  • ShadowMap does not dispose the textures it creates
  • JOGLRenderer does not dispose of its accumulation buffers, which hold texture objects
  • TextureCache removes texture proxies for valid textures when context is re-used
  • ShaderManager should detach shaders from the program after linking

Unfortunately it's not perfect yet. But that may or may not be an issue with this library.

@meinders meinders requested a review from PeerHeijnen April 22, 2026 10:19
@meinders meinders merged commit b7adc91 into master Apr 22, 2026
1 check passed
@meinders

Copy link
Copy Markdown
Member Author

(I'll make a follow-up PR if there are any serious issues.)

@meinders meinders deleted the ID-3404 branch April 22, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant