This repository was archived by the owner on Mar 4, 2019. It is now read-only.
Adding regex support in the IP whitelist#51
Closed
mattk42 wants to merge 2 commits intoAsquera:masterfrom
Closed
Conversation
Member
|
I support the idea, but if we want to provide that functionality we should really use proper CIDR notation with a netmask. |
Author
|
I do agree, I hacked this together yesterday to get a project I am working on moving. But I did realize afterwards that CIDR would have been nice. Looks like Apache's SubnetUtils library will make this easy (http://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/util/SubnetUtils.SubnetInfo.html). I will take a look at moving to that in the next week or so. |
Author
|
Ah, must have missed that one. That works for me, I'll go ahead and close this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add support for regex values in the ip whitelist config, identified by a leading tilda (~). This is useful in cases where you want to allow all traffic from a specific subnet to access elasticsearch without authentication.
This was accomplished by implementing the whitelist as an object array and then checking the types and doing what is appropriate in the contains methods.