Skip to content

Potential fixes for 2 code quality findings #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexkroman wants to merge 2 commits into from
Closed

Potential fixes for 2 code quality findings #119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a23f20
Apply suggested fix to tests/test_import_hygiene.py from Copilot Autofix
alexkroman Jun 12, 2026
a1fa32b
Apply suggested fix to tests/test_import_hygiene.py from Copilot Autofix
alexkroman Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions tests/test_import_hygiene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,23 @@

import subprocess
import sys
import textwrap

_PROBE = """
import sys
import aai_cli.main
heavy = {"jiwer", "rapidfuzz"}
loaded = sorted(heavy & {name.split(".")[0] for name in sys.modules})
assert not loaded, f"CLI import eagerly loaded: {loaded}"
"""
_PROBE = textwrap.dedent(
"""
import sys
import aai_cli.main
heavy = {"jiwer", "rapidfuzz"}
loaded = sorted(heavy & {name.split(".")[0] for name in sys.modules})
assert not loaded, f"CLI import eagerly loaded: {loaded}"
"""
).strip()


def test_cli_import_does_not_load_eval_scoring_stack():
# A fresh interpreter: the suite's own process has long since imported the
# scoring stack, so sys.modules can only be probed in a child.
result = subprocess.run(
[sys.executable, "-c", _PROBE], capture_output=True, text=True, timeout=120, check=False
[sys.executable, "-c", _PROBE], capture_output=True, text=True, timeout=15, check=False
)
assert result.returncode == 0, result.stderr
Loading