Deduplicate FakeYoutubeDL test doubles into a shared stub factory#144
Merged
Conversation
test_youtube.py defined the yt-dlp context-manager scaffolding (__init__/ __enter__/__exit__/prepare_filename) ten separate times, with each test varying only in what extract_info returns and what filename prepare_filename reports. Collapse that into one _ydl_stub(monkeypatch, extract, filename=...) factory that installs the fake and returns the captured opts/download dict, plus a _raising_extract helper for the failure-path tests. Net 110 fewer lines and each test now shows only the behavior it exercises. https://claude.ai/code/session_017jJDCfDpkpjaWhCpo1Perk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_youtube.py defined the yt-dlp context-manager scaffolding (init/
enter/exit/prepare_filename) ten separate times, with each test
varying only in what extract_info returns and what filename prepare_filename
reports. Collapse that into one _ydl_stub(monkeypatch, extract, filename=...)
factory that installs the fake and returns the captured opts/download dict,
plus a _raising_extract helper for the failure-path tests.
Net 110 fewer lines and each test now shows only the behavior it exercises.
https://claude.ai/code/session_017jJDCfDpkpjaWhCpo1Perk