Narrow handshake_status with isinstance instead of int() coercion#158
Merged
Conversation
getattr returns an untyped value off an arbitrary exception, so the prior int(code)/int(status) coercion would raise on a non-numeric .code rather than falling through to None. Guard each membership test with isinstance(..., int) so the value is provably an int before returning it, dropping the redundant int() call. Adds a non-auth (500) response-shape assertion to pin that only 401/403 qualify on either shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getattr returns an untyped value off an arbitrary exception, so the prior
int(code)/int(status) coercion would raise on a non-numeric .code rather than
falling through to None. Guard each membership test with isinstance(..., int)
so the value is provably an int before returning it, dropping the redundant
int() call. Adds a non-auth (500) response-shape assertion to pin that only
401/403 qualify on either shape.