Type llm messages with ChatCompletionMessageParam instead of suppressing#161
Merged
Conversation
The gateway `complete()` call carried a bare `# type: ignore[arg-type]` because `build_messages` returned `list[dict[str, str]]`, which isn't assignable to the OpenAI SDK's `Iterable[ChatCompletionMessageParam]`. Type the messages list and both function boundaries with the SDK's own param type so the `create()` call type-checks without the suppression. Tighten one build_messages test to compare the whole dict (matching its siblings), avoiding a not-required-key subscript on the now-typed union.
The token-usage block is only ever emitted as JSON, so its return type need not be dict[str, Any] — dict[str, object] matches the JSON-payload convention used throughout the codebase and drops the module's last Any (and the now-unused typing import).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gateway
complete()call carried a bare# type: ignore[arg-type]because
build_messagesreturnedlist[dict[str, str]], which isn'tassignable to the OpenAI SDK's
Iterable[ChatCompletionMessageParam].Type the messages list and both function boundaries with the SDK's own
param type so the
create()call type-checks without the suppression.Tighten one build_messages test to compare the whole dict (matching its
siblings), avoiding a not-required-key subscript on the now-typed union.