fix(telemetry): don't record a cancelled command as an error#210
Merged
Conversation
Cancelling a command (Ctrl-C / SIGTERM) is a normal part of CLI use, but build_event treated every non-success outcome as a failure: a "cancelled" outcome shipped with status:error and a reserved error.kind block, so it fed Datadog Error Tracking and inflated the crash rate (seen for `assembly llm` and `assembly transcripts get` cancellations). Treat "cancelled" alongside "success" as a non-error outcome via a _NON_ERROR_OUTCOMES set: it now ships as an info log with no error block, while genuine failures still feed Error Tracking unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fXXbmHqMUbRoEHssQEMmi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling a command (Ctrl-C / SIGTERM) is a normal part of CLI use, but
build_event treated every non-success outcome as a failure: a "cancelled"
outcome shipped with status:error and a reserved error.kind block, so it fed
Datadog Error Tracking and inflated the crash rate (seen for
assembly llmand
assembly transcripts getcancellations).Treat "cancelled" alongside "success" as a non-error outcome via a
_NON_ERROR_OUTCOMES set: it now ships as an info log with no error block, while
genuine failures still feed Error Tracking unchanged.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_019fXXbmHqMUbRoEHssQEMmi