refactor(voices): extract shared --list-voices rendering and voice validation#212
Merged
Merged
Conversation
…lidation The `agent` and `agent-cascade` slices independently reimplemented the same grouped `--list-voices` rendering loop and the same unknown-voice usage guard. Both catalogs stay separate (Voice Agent ids vs the TTS catalog); only the presentation/validation was duplicated. - core/choices.py: add `render_grouped`, the label/indent/blank-line block renderer both `format_voice_list`s now call. - app/agent_shared.py: add `validate_voice`, the unknown-`--voice` UsageError guard both run paths now call (joins the existing `resolve_system_prompt`). Behavior-preserving; covered by the existing voice/list-voices/error snapshot tests plus a direct `render_grouped` test for the empty-group branch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pPWS42r4R3qKmzXzcQYtk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
agentandagent-cascadeslices independently reimplemented the samegrouped
--list-voicesrendering loop and the same unknown-voice usage guard.Both catalogs stay separate (Voice Agent ids vs the TTS catalog); only the
presentation/validation was duplicated.
render_grouped, the label/indent/blank-line blockrenderer both
format_voice_lists now call.validate_voice, the unknown---voiceUsageErrorguard both run paths now call (joins the existing
resolve_system_prompt).Behavior-preserving; covered by the existing voice/list-voices/error snapshot
tests plus a direct
render_groupedtest for the empty-group branch.Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_015pPWS42r4R3qKmzXzcQYtk