Refactor eval and stream exec modules below the size limit#214
Merged
Conversation
Both command exec modules were approaching the 500-line gate. Split each on its natural seam into a private helper module (the documented underscore convention), keeping the run path lean: - evaluate/_exec.py (488 -> 389): human-mode rendering moves to evaluate/_render.py; the run path keeps scoring/orchestration and calls _render.render via output.emit. - stream/_exec.py (481 -> 369): save-destination resolution moves to stream/_save.py (SaveTargets + the --save-dir / --save-audio matrix); run_stream calls _save.resolve_save_targets. Tests repointed to the new modules (private-helper refs and the datetime / SaveTargets patch targets). No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Bkx51XDcYBdnot1EF8h9U
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both command exec modules were approaching the 500-line gate. Split each on
its natural seam into a private helper module (the documented underscore
convention), keeping the run path lean:
evaluate/_render.py; the run path keeps scoring/orchestration and calls
_render.render via output.emit.
stream/_save.py (SaveTargets + the --save-dir / --save-audio matrix);
run_stream calls _save.resolve_save_targets.
Tests repointed to the new modules (private-helper refs and the datetime /
SaveTargets patch targets). No behavior change.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_018Bkx51XDcYBdnot1EF8h9U