Unify CLI tables on one minimal, consistent style#22
Merged
Conversation
Every listing command hand-built a Rich table with the default heavy box, and the two key/value detail views (whoami, sessions get) were styled differently — one a borderless grid, one a boxed table with raw field names. Introduce two shared factories in output.py as the single source of truth: - data_table(): a quiet header-rule table (box.SIMPLE_HEAD) in the brand heading style, used by transcripts/keys/sessions list, usage, limits, audit. - detail_table(): a borderless label/value grid with a muted label column, now shared by whoami and sessions get. sessions get field labels are humanized (underscores -> spaces) to match the clarity of whoami's labels. Adds unit tests for both factories plus human-render tests for whoami, keys list, and the humanized sessions get labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every listing command hand-built a Rich table with the default heavy box,
and the two key/value detail views (whoami, sessions get) were styled
differently — one a borderless grid, one a boxed table with raw field names.
Introduce two shared factories in output.py as the single source of truth:
heading style, used by transcripts/keys/sessions list, usage, limits, audit.
now shared by whoami and sessions get.
sessions get field labels are humanized (underscores -> spaces) to match the
clarity of whoami's labels. Adds unit tests for both factories plus human-render
tests for whoami, keys list, and the humanized sessions get labels.