Remove CodeQL from local check.sh gate#225
Merged
Merged
Conversation
CodeQL is the slowest gate (~minutes) and depends on nothing else in the local pipeline. It was already enforced independently by the codeql.yml workflow, and ci.yml's check job never ran it anyway (no codeql on the hosted runner's PATH, so the step self-skipped there). Removing it from check.sh therefore loses no CI coverage and roughly halves the local gate wall-clock (~165s -> ~83s on a 4-core box). scripts/codeql_gate.py is kept so a code-scanning alert can still be reproduced locally on demand. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TSGokAz8uYHj5PnWfYh8LP
alexkroman
force-pushed
the
claude/confident-ramanujan-hed2j4
branch
from
65da3d8 to
a4fc7fc
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the CodeQL security analysis step from the local
check.shgate and update documentation accordingly. CodeQL is now exclusively run in CI viacodeql.yml, eliminating redundant local execution and significantly improving local development speed.Changes
scripts/codeql_gate.py. Replaced with a comment explaining that CodeQL is CI-only and directing users to the manual reproduction command if needed.Rationale
CodeQL is the slowest gate (~minutes) and was already being enforced in CI by
codeql.yml, which runs the same security and quality suites and uploads results to GitHub's code-scanning/quality tabs. The CI workflow (ci.yml) never actually ran the local CodeQL step either (hosted runners lack CodeQL on PATH), so removing it from the local gate loses no CI coverage while keepingcheck.shfast for developers. The same analysis can still be reproduced locally viauv run python scripts/codeql_gate.pyif needed.https://claude.ai/code/session_01TSGokAz8uYHj5PnWfYh8LP