Skip to content

Clarify dependency removal PR policy in AGENTS.md #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexkroman merged 2 commits into from
Jun 17, 2026
Merged

Clarify dependency removal PR policy in AGENTS.md #228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c071701
Extend dependency-PR rule to cover removals
claude Jun 17, 2026
4cea100
Merge remote-tracking branch 'origin/main' into claude/serene-bardeen…
claude Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ structured so independent changes stay in disjoint files. Keep it that way:
declaration (see `aai_cli/AGENTS.md`). If you find yourself editing a shared
list to add a command, you're fighting the convention.
- **Dependency changes are not part of feature PRs.** `uv.lock` is the one file
two branches can never merge cleanly; add or bump dependencies in a
two branches can never merge cleanly; add, bump, or remove dependencies in a
dedicated, single-purpose PR so feature branches don't collide in the
lockfile.
lockfile. Dropping a dependency still rewrites `uv.lock`, so a removal gets
its own PR too — even when it rides along with deleting the code that used it.
- **Land through the merge queue.** The diff-scoped gates compare against
`origin/main`, which moves constantly; two individually-green PRs can be
jointly red. PRs should merge via GitHub's merge queue (a repository setting)
Expand Down
Loading