Make assembly code tool-approval compact and add a working spinner#233
Merged
Conversation
The tool-approval modal in the `assembly code` TUI took over the whole screen. Replace it with a transparent-background, bottom-docked compact panel so the transcript stays visible, plus an "Auto-approve (a)" option that flips the session to auto and skips later prompts. Give AskScreen the same compact treatment. Add a working indicator (spinner + elapsed seconds) above the prompt bar that animates while a turn runs and hides when it finishes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assembly codetool-approval prompt no longer takes over the whole screen:ApprovalScreenis now a transparent (non-dimming), bottom-docked compact box, so the transcript stays visible above it.manual→autostatus badge, and silently approves later tool calls.AskScreengot the same compact, bottom-docked treatment.✶ Working… (46s)) docked just above the prompt bar, animating while a turn runs and hiding when it finishes.Testing
tests/test_code_tui.py: updated the modal tests for the new string-valued decision, added auto-approve + badge-refresh + spinner (format/start/tick/stop) tests, an_approval_decisionunit test, and a regression guard asserting the approval box stays compact and bottom-anchored (not full-screen)../scripts/check.shpasses end-to-end (incl. 100% patch coverage + diff-scoped mutation gate).🤖 Generated with Claude Code