-
Notifications
You must be signed in to change notification settings - Fork 0
assembly code/live: voice-interrupt UX, modal dismissal, concise speech, gemini live default #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dc3fa64
assembly code/live: voice-interrupt UX, modal dismissal, concise spee…
alexkroman-assembly 0c8da5a
Strip JSON-Schema metadata keys gateway models reject from tool defin…
alexkroman-assembly b22495d
Strip the full set of Gemini-rejected JSON-Schema keywords from tool …
alexkroman-assembly b9fd7f6
assembly live: space replies in the transcript; silence firecrawl imp…
alexkroman-assembly d9e4ffb
assembly live: surface a failed reply turn instead of dying silently
alexkroman-assembly 13c9270
assembly code voice: never trap on Ctrl-C; assembly live default -> c…
alexkroman-assembly 169946c
assembly live: bound MCP tool loading with a timeout so a slow server…
alexkroman-assembly fe9e60a
assembly live: slim agent to web search only + keyboard interrupt to …
alexkroman-assembly be20e9c
assembly live: show a tool-call affordance as the agent works
alexkroman-assembly 55c0018
assembly live: exit cleanly on Ctrl-C during TUI setup
alexkroman-assembly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Embedding the raw exception (f"the agent couldn't complete the turn: {exc}") may expose user/tool data. Redact or sanitize exception text before including it in CLIError messages.
Details
✨ AI Reasoning
The code now catches all Exceptions from the agent graph and raises a CLIError whose message embeds the original exception's string representation. That original exception may include user-controlled data, tool outputs, or other sensitive content. The CLIError is then recorded and shown to the user/UI by other parts of the cascade, so this change increases the risk of leaking unsanitized user input or external payloads to logs/terminal.
🔧 How do I fix it?
Keep sensitive data such as emails, passwords, and tokens out of logs. When logging values tied to a user, prefer a safe identifier like a user ID over the raw input, and strip line breaks from any user-provided text you do log.
Reply
@AikidoSec feedback: [FEEDBACK]to get better review comments in the future.Reply
@AikidoSec ignore: [REASON]to ignore this issue.More info