Simplify: dedupe optional-key resolution, status cells, doctor checks#48
Merged
Conversation
- config.resolve_api_key_optional centralizes the NotAuthenticated-swallowing that init/keys and onboard's _has_key each re-implemented. - theme.status_text wraps the repeated Text(value, status_style(value)) used by transcripts/sessions list rendering (drops two rich.text imports). - doctor._check collapses the repeated Check dict literals into one builder. https://claude.ai/code/session_01VCThQ9Rcvt28CQhyx6qPts
These tests bound the single fixed LOOPBACK_PORT in a worker thread for every case. Under CI load + random ordering a server could still hold the port when the next test's worker bound it, raising APIError inside the thread (surfacing as PytestUnhandledThreadExceptionWarning, which the suite treats as an error) and cascading into neighbouring tests. Give each test its own OS-assigned port so the cases stop sharing a network resource; capture_callback is unchanged. https://claude.ai/code/session_01VCThQ9Rcvt28CQhyx6qPts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
that init/keys and onboard's _has_key each re-implemented.
transcripts/sessions list rendering (drops two rich.text imports).
https://claude.ai/code/session_01VCThQ9Rcvt28CQhyx6qPts