Remove per-PR macOS formula build, move to release workflow#71
Merged
Conversation
The formula-install job built the formula from source on macOS every PR (rust + cryptography native builds, 40-minute timeout), which made it the slowest job in the workflow by far. The real install path is already exercised where it matters: release.yml runs brew install --build-bottle when a tag is cut, and brew style still lints the formula on every PR. https://claude.ai/code/session_01Q2127PjnBnuW9tXi58Yn6N
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
formula-installCI job that performed a realbrew installbuild on every PR. This job was computationally expensive (40-minute timeout for Rust + cryptography native builds) and provided limited feedback value for PR review cycles. Real formula builds now run only during release (viarelease.ymlwhen a tag is cut).Changes
Removed
formula-installjob from.github/workflows/ci.yml(lines 192–241)brew install --build-from-source+brew teststepsUpdated CI comments to reflect the new workflow
brew style(RuboCop-based linting) still runs on every PR for idiom checkingbrew install --build-bottlenow runs only inrelease.ymlwhen a tag is cutRationale
The per-PR formula build was a bottleneck that didn't align with typical PR feedback needs. The stricter
brew audit --strict --onlineand actual release builds provide sufficient validation at the appropriate stage in the release process.https://claude.ai/code/session_01Q2127PjnBnuW9tXi58Yn6N