fix(computer): support 'idle' status for shipyard_neo booter#8806
Open
darkwing0605 wants to merge 1 commit into
Open
fix(computer): support 'idle' status for shipyard_neo booter#8806darkwing0605 wants to merge 1 commit into
darkwing0605 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the sandbox readiness check in shipyard_neo.py to accept both 'ready' and 'idle' as valid statuses. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider updating the log message to reflect that both
readyandidleare accepted states (e.g., log the actual status) so debugging future status-related issues is clearer. - If Shipyard Neo may introduce additional non-terminal statuses that should be treated as ready in the future, you might centralize the allowed statuses into a constant or small helper to avoid scattering status literals.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider updating the log message to reflect that both `ready` and `idle` are accepted states (e.g., log the actual status) so debugging future status-related issues is clearer.
- If Shipyard Neo may introduce additional non-terminal statuses that should be treated as ready in the future, you might centralize the allowed statuses into a constant or small helper to avoid scattering status literals.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 120-second execution timeout issues when using the
shipyard_neobooter in AstrBot.Newer versions of Shipyard Neo return an
idlestatus instead ofreadyonce the sandbox container is initialized. AstrBot previously kept polling indefinitely until it hit a 120s timeout.Modifications / 改动点
astrbot/core/computer/booters/shipyard_neo.py: Updated the_wait_until_readylogic to white-list bothreadyandidlestatuses for successful sandbox initialization.This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Bug Fixes: