Skip to content

fix(computer): support 'idle' status for shipyard_neo booter#8806

Open
darkwing0605 wants to merge 1 commit into
AstrBotDevs:masterfrom
darkwing0605:fix/shipyard-neo-idle-status
Open

fix(computer): support 'idle' status for shipyard_neo booter#8806
darkwing0605 wants to merge 1 commit into
AstrBotDevs:masterfrom
darkwing0605:fix/shipyard-neo-idle-status

Conversation

@darkwing0605

@darkwing0605 darkwing0605 commented Jun 15, 2026

Copy link
Copy Markdown

This PR fixes 120-second execution timeout issues when using the shipyard_neo booter in AstrBot.
Newer versions of Shipyard Neo return an idle status instead of ready once the sandbox container is initialized. AstrBot previously kept polling indefinitely until it hit a 120s timeout.

Modifications / 改动点

  • astrbot/core/computer/booters/shipyard_neo.py: Updated the _wait_until_ready logic to white-list both ready and idle statuses for successful sandbox initialization.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

[2026-06-15 22:24:52.372] [Core] [INFO] [computer.computer_client:607]: [Computer] Shipyard Neo config: endpoint=http://bay:8114, profile=python-default, ttl=3600
[2026-06-15 22:24:52.380] [Core] [INFO] [booters.shipyard_neo:551]: [Computer] Using user-specified profile: python-default
[2026-06-15 22:24:52.416] [Core] [INFO] [booters.shipyard_neo:482]: [Computer] Sandbox sandbox-70d4cec0d67c is ready (profile=python-default)
[2026-06-15 22:24:52.417] [Core] [INFO] [booters.shipyard_neo:456]: Got Shipyard Neo sandbox: sandbox-70d4cec0d67c (profile=python-default, capabilities=['filesystem', 'shell', 'python'], auto=False)
[2026-06-15 22:24:52.417] [Core] [INFO] [computer.computer_client:634]: [Computer] Sandbox booted successfully: type=shipyard_neo, session=default:FriendMessage:<id>

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Prevent Shipyard Neo booted sandboxes that report an idle status from causing 120-second execution timeouts by accepting idle as a ready state.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:core The bug / feature is about astrbot's core, backend labels Jun 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sandbox readiness check in shipyard_neo.py to accept both 'ready' and 'idle' as valid statuses. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider updating the log message to reflect that both ready and idle are accepted states (e.g., log the actual status) so debugging future status-related issues is clearer.
  • If Shipyard Neo may introduce additional non-terminal statuses that should be treated as ready in the future, you might centralize the allowed statuses into a constant or small helper to avoid scattering status literals.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider updating the log message to reflect that both `ready` and `idle` are accepted states (e.g., log the actual status) so debugging future status-related issues is clearer.
- If Shipyard Neo may introduce additional non-terminal statuses that should be treated as ready in the future, you might centralize the allowed statuses into a constant or small helper to avoid scattering status literals.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core The bug / feature is about astrbot's core, backend size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant