fix(embedding): 通用修复 embedding_dimensions 参数校验，解决 SiliconFlow 等兼容接口报 400 的问题

[Rat0323]

📝 PR 摘要

通用修复 embedding_dimensions 为 0（或默认值）时引发的兼容性问题与建库阻塞问题。移除了针对单一服务商的硬编码，提升了对类 OpenAI 接口（如 SiliconFlow, vLLM）的泛用性兼容。

🐛 问题根源

1. 接口参数不兼容：原逻辑在未配置维度时，会向 API 发送无效的 dimensions: 0。导致严格校验该参数的平台（如 SiliconFlow）返回 HTTP 400 错误。
2. 预检逻辑误拦截：当修复接口调用后，API 成功返回真实维度（如 1024）。但 knowledge_base_service.py 严格校验 1024 != config_dim(0)，导致正常模型被系统误判拦截，知识库创建失败。

🛠️ 修复方案

1. openai_embedding_source.py (接口层)
   • 参数过滤：仅当 embedding_dimensions > 0 时，才向 kwargs 注入 dimensions 参数。
   • 移除特判：删除了此前针对 api.siliconflow.cn 的特定域名拦截逻辑，改为通用处理。支持 dimensions 的官方接口不受影响，拒绝无效维度的接口自动规避。
2. knowledge_base_service.py (业务层)
   • 放宽默认值预检：修改判断逻辑为 if configured_dim != 0 and actual_dim != configured_dim:。当配置为 0 时，信任并接纳 API 探测返回的真实维度用于 Faiss 初始化；仅在用户显式配置错误维度时拦截。

📊 测试验证

测试模型：SiliconFlow (BAAI/bge-m3)

配置值 (embedding_dimensions)	接口 Payload 表现	维度预检结果	最终动作
0 / 留空	不发送 dimensions	跳过拦截，获取实际维度 1024	✅ 成功基于 1024 维建库
1024 (正例)	发送 dimensions: 1024	1024 == 1024，校验通过	✅ 成功建库
768 (反例)	发送 dimensions: 768	1024 != 768	❌ 抛出 ValueError，拦截成功

[gemini-code-assist]

Code Review

This pull request simplifies the _embedding_kwargs method in openai_embedding_source.py by removing a temporary workaround for the SiliconFlow provider and ensuring that the dimensions parameter is only set if its value is greater than zero. Feedback suggests checking for None or empty string values for embedding_dimensions before attempting to convert it to an integer, which prevents unnecessary warning logs from flooding the console when the field is left blank in the WebUI.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[sourcery-ai]

Hey - I've left some high level feedback:

• When embedding_dimensions is configured as 0 or a negative value it is now silently ignored; consider logging a low-level warning or info in that case so misconfigurations are easier to spot while still avoiding the SiliconFlow 400s.
• Since the provider-specific SiliconFlow branch is removed, it might be worth adding a short inline comment near the dim_val > 0 check to clarify that omitting dimensions is intentional for OpenAI-compatible providers that reject this parameter entirely.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- When `embedding_dimensions` is configured as `0` or a negative value it is now silently ignored; consider logging a low-level warning or info in that case so misconfigurations are easier to spot while still avoiding the SiliconFlow 400s.
- Since the provider-specific SiliconFlow branch is removed, it might be worth adding a short inline comment near the `dim_val > 0` check to clarify that omitting `dimensions` is intentional for OpenAI-compatible providers that reject this parameter entirely.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}