Fix lyrics page breaking navigation#286
Open
Maaboudoufu wants to merge 1 commit into
Open
Conversation
Maaboudoufu
changed the title
Maaboudoufu
force-pushed
the
fix-nav-blocked-by-lyrics-typeerror
branch
from
July 14, 2026 14:27
ce1cab4 to
fc9b26b
Compare
Maaboudoufu
force-pushed
the
fix-nav-blocked-by-lyrics-typeerror
branch
from
July 14, 2026 14:36
fc9b26b to
e99b7c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285
querySelector -> querySelectorAll.
[2]on a single element is undefined, so.innerTextthrew inside the History.listen callback and cancelled every navigation while the lyrics page was open. Added a?.too for songs with less than 3 lines.