When the bot automatically marks you as not following, it also adds a message to the thread, in addition to emoji react#3117
Open
derektumolo wants to merge 9 commits intoAsyncTI4:masterfrom
Open
Conversation
adds a check for "The game is currently waiting on " to say "person" instead of "people" if its only 1 person
Contributor
Author
|
expecting plenty of feedback, but i think this works well, and would definitely make things a bit clearer in the thread. |
Jazzxhands
approved these changes
May 18, 2025
Collaborator
Jazzxhands
left a comment
Jazzxhands
left a comment
There was a problem hiding this comment.
Neither comment is a big deal, really. Looks good
| } | ||
|
|
||
| private static boolean playerCantFollowNoDocks(Game game, Player player, Player p2, int scToPlay) { | ||
| if (scToPlay == 6 && !p2.hasUnit("ghoti_flagship") && !ButtonHelper.getTilesOfPlayersSpecificUnits(game, p2, UnitType.Spacedock).contains(p2.getHomeSystemTile())) { |
Collaborator
There was a problem hiding this comment.
Preexisting, but you could add an && !p2.getUnfollowedSCs().contains(4) here, in case the player wants to get a dock from construction and then follow warfare
| } | ||
|
|
||
| private static String pluralPerson(int num) { | ||
| private static String pluralPerson(int num){ |
Collaborator
There was a problem hiding this comment.
Not sure which IDE you're using, but make sure you configure the formatter. If you're using VSCode, it's just making sure the following two lines are in .vscode/settings.json:
"java.format.settings.url": "eclipse-formatter.xml",
"editor.formatOnSave": true,
Contributor
|
Can you also do this for when it marks you as not following due to your pre-set no-follow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.