Skip to content

Trade SC debts are placed into an appropriately named (Trade R{round}…#4373

Open
Mjb141 wants to merge 1 commit intoAsyncTI4:masterfrom
Mjb141:trade-sc-debt-pools
Open

Trade SC debts are placed into an appropriately named (Trade R{round}…#4373
Mjb141 wants to merge 1 commit intoAsyncTI4:masterfrom
Mjb141:trade-sc-debt-pools

Conversation

@Mjb141
Copy link

@Mjb141 Mjb141 commented Jan 31, 2026

…) pool by default

Simple QoL change. "Sent 1 debt" from following trade sc goes into a pool named Trade R<round>. Separates trade sc debt from regular trade debt, and for what few games don't always pay back trade at agenda (hidden agenda games in particular) it's nice to know where the debt came from.

@bradleysigma
Copy link
Contributor

Hmmmm, I would suggest that debt that can be sent with buttons must be able to be cleared with buttons. The only way that this debt can be cleared is with a slash command.
It won't interact with things such as automated reminders during the agenda phase, nor the transaction generator.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the quality of life for debt tracking by introducing round-specific debt pools for Trade Strategy Card debts. When a player sends debt following the Trade SC, the debt now goes into a pool named "Trade R{round}" instead of the generic "Debt Account" pool.

Changes:

  • Modified debt pool naming for Trade SC debts to include the current round number
  • Updated the user-facing message to reflect the new pool name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Mjb141
Copy link
Author

Mjb141 commented Feb 1, 2026

Both good points @bradleysigma, I'll look at those later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants