[Snyk] Security upgrade node-sass from 6.0.1 to 9.0.0#23
[Snyk] Security upgrade node-sass from 6.0.1 to 9.0.0#23karimkawambwa wants to merge 1 commit intomasterfrom
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-QS-14724253
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "css-loader": "^6.2.0", | ||
| "mini-css-extract-plugin": "^2.1.0", | ||
| "node-sass": "^6.0.1", | ||
| "node-sass": "^9.0.0", |
There was a problem hiding this comment.
Bug: The yarn.lock file is out of sync with package.json. This will cause the old, vulnerable version of node-sass to be installed, negating the security fix.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The package.json file was updated to change the node-sass dependency from version ^6.0.1 to ^9.0.0 to fix a high-severity vulnerability. However, the yarn.lock file was not regenerated. As a result, any yarn install command, whether run by developers or in a CI/CD pipeline, will prioritize the lockfile and install the old, vulnerable version 6.0.1. This completely negates the security fix this pull request is intended to deliver, leaving the application exposed to the vulnerability.
💡 Suggested Fix
Run yarn install or an equivalent command to regenerate the yarn.lock file based on the changes in package.json. Commit the updated yarn.lock file to the pull request.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L17
Potential issue: The `package.json` file was updated to change the `node-sass`
dependency from version `^6.0.1` to `^9.0.0` to fix a high-severity vulnerability.
However, the `yarn.lock` file was not regenerated. As a result, any `yarn install`
command, whether run by developers or in a CI/CD pipeline, will prioritize the lockfile
and install the old, vulnerable version `6.0.1`. This completely negates the security
fix this pull request is intended to deliver, leaving the application exposed to the
vulnerability.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8136148
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-QS-14724253
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling