[Snyk] Security upgrade shakapacker from 6.5.5 to 9.5.0#25
Open
karimkawambwa wants to merge 1 commit intomasterfrom
Open
[Snyk] Security upgrade shakapacker from 6.5.5 to 9.5.0#25karimkawambwa wants to merge 1 commit intomasterfrom
karimkawambwa wants to merge 1 commit intomasterfrom
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-SHAKAPACKER-14912603
| gem 'puma' | ||
| gem 'rails' | ||
| gem 'shakapacker' | ||
| gem 'shakapacker', '>= 9.5.0' |
There was a problem hiding this comment.
Bug: The shakapacker gem is updated to v9.5.0+ while the corresponding npm package remains at v6.5.5, creating an incompatible version mismatch that will break the application.
Severity: CRITICAL
Suggested Fix
Update the shakapacker package in package.json to a version compatible with the gem (e.g., ~9.5.0). Run bundle install and yarn install to update Gemfile.lock and yarn.lock. Also, update the code to use the new APIs from shakapacker v9+, such as changing require "webpacker" to require "shakapacker" and using generateWebpackConfig().
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: Gemfile#L25
Potential issue: The `Gemfile` updates the `shakapacker` gem to version `9.5.0+`, but
`package.json` and `yarn.lock` are not updated, leaving the JavaScript package at
`6.5.5`. This version mismatch will cause critical failures. The new gem version (v9+)
has removed APIs that are still used in the codebase, such as `require "webpacker"` in
`bin/webpacker` and the `webpackConfig` export in `webpack.config.js`. Consequently,
asset compilation will fail with a `LoadError` or `TypeError`, and the development
server will not start, making the application non-functional.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 1 vulnerabilities in the rubygems dependencies of this project.
Snyk changed the following file(s):
GemfileVulnerabilities that will be fixed with an upgrade:
SNYK-RUBY-SHAKAPACKER-14912603
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.