Skip to content

[Snyk] Security upgrade shakapacker from 6.5.5 to 9.5.0#25

Open
karimkawambwa wants to merge 1 commit intomasterfrom
snyk-fix-30e4e5fc88def86a39ae614ebccc2f27
Open

[Snyk] Security upgrade shakapacker from 6.5.5 to 9.5.0#25
karimkawambwa wants to merge 1 commit intomasterfrom
snyk-fix-30e4e5fc88def86a39ae614ebccc2f27

Conversation

@karimkawambwa
Copy link

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the rubygems dependencies of this project.

Snyk changed the following file(s):

  • Gemfile
⚠️ Warning
Failed to update the Gemfile.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Inclusion of Sensitive Information in Source Code
SNYK-RUBY-SHAKAPACKER-14912603
  721  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-RUBY-SHAKAPACKER-14912603
gem 'puma'
gem 'rails'
gem 'shakapacker'
gem 'shakapacker', '>= 9.5.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The shakapacker gem is updated to v9.5.0+ while the corresponding npm package remains at v6.5.5, creating an incompatible version mismatch that will break the application.
Severity: CRITICAL

Suggested Fix

Update the shakapacker package in package.json to a version compatible with the gem (e.g., ~9.5.0). Run bundle install and yarn install to update Gemfile.lock and yarn.lock. Also, update the code to use the new APIs from shakapacker v9+, such as changing require "webpacker" to require "shakapacker" and using generateWebpackConfig().

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: Gemfile#L25

Potential issue: The `Gemfile` updates the `shakapacker` gem to version `9.5.0+`, but
`package.json` and `yarn.lock` are not updated, leaving the JavaScript package at
`6.5.5`. This version mismatch will cause critical failures. The new gem version (v9+)
has removed APIs that are still used in the codebase, such as `require "webpacker"` in
`bin/webpacker` and the `webpackConfig` export in `webpack.config.js`. Consequently,
asset compilation will fail with a `LoadError` or `TypeError`, and the development
server will not start, making the application non-functional.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants