This repository was archived by the owner on May 10, 2024. It is now read-only.
Officially integrate the LuckPerms API into TFM#315
Open
Paldiu wants to merge 15 commits intoRELEASE-2023.03from
Open
Officially integrate the LuckPerms API into TFM#315Paldiu wants to merge 15 commits intoRELEASE-2023.03from
Paldiu wants to merge 15 commits intoRELEASE-2023.03from
Conversation
Moved command loading into a runnable that will execute on the first server tick. This way, we can ensure that all the plugins are loaded before we load our commands, so TFD4J and Shop can both have their respective commands loaded in.
ghost
suggested changes
Apr 11, 2023
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM, although there seem to be a few style violations.
| return; | ||
| } | ||
|
|
||
| if (result == null) { |
| HierarchyProvider.ADMIN.getHierarchy() | ||
| .promoteUser(GroupProvider.getUser(player)) | ||
| .whenComplete((result, ex) -> { | ||
| if (ex != null) { |
| FUtil.adminAction(sender.getName(), "Promoting " + player.getName() + " to the next rank", true); | ||
| HierarchyProvider.ADMIN.getHierarchy() | ||
| .promoteUser(GroupProvider.getUser(player)) | ||
| .whenComplete((result, ex) -> { |
| { | ||
| msgNew("<red>Failed to promote <player> to the next rank.", player(player)); | ||
| return; | ||
| } else { |
| }); | ||
| } | ||
|
|
||
| private Map<String, Command> getFallbackCommands() { |
|
|
||
| private Map<String, Command> getFallbackCommands() { | ||
| final Map<String, Command> fallbackCommands = new HashMap<>(); | ||
| for (final Map.Entry<String, Command> entry : Bukkit.getCommandMap().getKnownCommands().entrySet()) { |
| private Map<String, Command> getFallbackCommands() { | ||
| final Map<String, Command> fallbackCommands = new HashMap<>(); | ||
| for (final Map.Entry<String, Command> entry : Bukkit.getCommandMap().getKnownCommands().entrySet()) { | ||
| if (!(entry.getValue() instanceof PluginIdentifiableCommand)) { |
| { | ||
| if (!manager.isLoaded(name) || !trackSet.contains(manager.getTrack(name))) | ||
| { | ||
| return manager.createAndLoadTrack(name).thenApplyAsync(a -> { |
| @@ -176,17 +182,26 @@ public void updateDisplay(Player player) | |||
| } else | |||
Build has a critical error where sql data is being interpreted incorrectly which is odd considering no sql changes were made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers quite a bit of ground, namely: