Skip to content

Estimate taproot witness length in fees#240

Merged
matthewjablack merged 4 commits into
masterfrom
alex/eng-1431-dynamic-witness-length-for-taproot-in-txfinalizer-and
Jul 17, 2026
Merged

Estimate taproot witness length in fees#240
matthewjablack merged 4 commits into
masterfrom
alex/eng-1431-dynamic-witness-length-for-taproot-in-txfinalizer-and

Conversation

@w3irdrobot

Copy link
Copy Markdown
Collaborator

Summary

  • Add script-type witness length helpers for funding fee estimation, including Taproot key-path spends.
  • Allow TxFinalizer helper factories and coin selection fee estimates to use dynamic witness lengths.
  • Add coverage for lower Taproot fee estimates and Taproot-aware coin selection.

Validation

  • npm run build --workspace @node-dlc/core
  • npm run lint

Comment thread packages/core/lib/dlc/TxFinalizer.ts
Comment thread packages/core/lib/dlc/CoinSelect.ts Outdated

@matthewjablack matthewjablack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing, LGTM 🎉

@matthewjablack
matthewjablack merged commit a75adc3 into master Jul 17, 2026
2 of 4 checks passed
@matthewjablack
matthewjablack deleted the alex/eng-1431-dynamic-witness-length-for-taproot-in-txfinalizer-and branch July 17, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants