Skip to content

Optimize storage, standardize access patterns, and fix security issue… #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredericklamar342-prog wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Optimize storage, standardize access patterns, and fix security issue… #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b61199
Optimize storage, standardize access patterns, and fix security issue…
Mar 30, 2026
17fb91a
Auto-link fixed issues #32, #34, #35, #44 on GitHub
Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ISSUES_FIX_SUMMARY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ This document summarizes the fixes for 4 GitHub issues in the AtomicIP smart con

## Issue #32: Fix reveal_key does not verify decryption key against IP commitment

**Fixes #32**
**Status:** ✅ ALREADY FIXED
**Location:** `contracts/atomic_swap/src/lib.rs` lines 188-192
**Fix:** The `reveal_key` function now calls `ip_registry.verify_commitment()` to verify that the revealed secret and blinding factor match the stored commitment hash before marking the swap as Completed.
Expand All @@ -24,6 +25,7 @@ if !valid {

## Issue #34: Fix reveal_key does not release escrowed payment to seller

**Fixes #34**
**Status:** ✅ FIXED
**Location:** `contracts/atomic_swap/src/lib.rs` lines 202-207
**Fix:** Added token transfer to release escrowed payment to seller after successful key verification.
Expand All @@ -47,6 +49,7 @@ token::Client::new(&env, &swap.token).transfer(

## Issue #35: Fix cancel_swap does not refund buyer's escrowed payment

**Fixes #35**
**Status:** ✅ FIXED
**Location:** `contracts/atomic_swap/src/lib.rs` lines 286-291
**Fix:** Added token transfer to refund buyer when an Accepted swap is cancelled after expiry.
Expand Down Expand Up @@ -107,6 +110,7 @@ fn test_buyer_refunded_on_cancel_expired() {

## Issue #44: Fix commit_ip does not check for duplicate commitment hashes

**Fixes #44**
**Status:** ✅ ALREADY FIXED
**Location:** `contracts/ip_registry/src/lib.rs` lines 75-81
**Fix:** Added duplicate commitment hash check using the `CommitmentOwner` storage key.
Expand Down
Loading