Skip to content

Use pull_request trigger and remove LAVA workflow job #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ffrancis123 merged 1 commit into from
Jun 5, 2026
+2 −19
Merged

Use pull_request trigger and remove LAVA workflow job #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions .github/workflows/pre_merge_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ run-name: ${{ github.event.pull_request.number && 'Pre Merge Build PR:' || 'Pre

on:
workflow_dispatch:
pull_request_target:
pull_request:
types: [opened, synchronize, reopened]
branches:
- master
Expand Down Expand Up @@ -91,21 +91,11 @@ jobs:
echo "has_tests=$HAS_TESTS" >> "$GITHUB_OUTPUT"
echo "Tests enabled: $HAS_TESTS"
trigger_lava:
needs: [process_image, filter_test_matrix]
if: needs.filter_test_matrix.outputs.has_tests == 'true'
permissions:
checks: write
pull-requests: write
uses: AudioReach/audioreach-workflows/.github/workflows/test.yml@master
secrets: inherit
with:
build_matrix: ${{ needs.filter_test_matrix.outputs.test_matrix }}
# This job ensures the workflow always completes successfully
# even when trigger_lava is skipped due to no tests
workflow_complete:
needs: [load_parameters, build, process_image, filter_test_matrix, trigger_lava]
needs: [load_parameters, build, process_image, filter_test_matrix]
if: always()
runs-on: ubuntu-latest
steps:
Expand All @@ -116,7 +106,6 @@ jobs:
echo "build: ${{ needs.build.result }}"
echo "process_image: ${{ needs.process_image.result }}"
echo "filter_test_matrix: ${{ needs.filter_test_matrix.result }}"
echo "trigger_lava: ${{ needs.trigger_lava.result }}"
echo ""
if [ "${{ needs.filter_test_matrix.outputs.has_tests }}" == "false" ]; then
Expand All @@ -132,10 +121,4 @@ jobs:
exit 1
fi
# trigger_lava can be skipped or success, both are acceptable
if [ "${{ needs.trigger_lava.result }}" == "failure" ]; then
echo "❌ Testing failed"
exit 1
fi
echo "✅ Workflow completed successfully"
Loading