Skip to content

Add NOGROUP suffix if not disc for BHD#1345

Open
glibbright wants to merge 1 commit into
Audionut:masterfrom
glibbright:bhd-nogroup
Open

Add NOGROUP suffix if not disc for BHD#1345
glibbright wants to merge 1 commit into
Audionut:masterfrom
glibbright:bhd-nogroup

Conversation

@glibbright
Copy link
Copy Markdown

Adheres to rule 3.3.9. Technically they don't specify WEBRIP should have NOGROUP but I would be surprised if that was really the case, it's probably just missed off the rule.

Note this does not solve for rule 3.3.8 - that would require inspection of the folder names.

@github-actions
Copy link
Copy Markdown

Thanks for taking the time to contribute to this project. Upload Assistant is currently in a complete rewrite, and no new development is being conducted on this python source at this time.

If you have come this far, please feel free to leave open, any pull requests regarding new sites being added to the source, as these can serve as the baseline for later conversion.

If your pull request relates to a critical bug, this will be addressed in this code base, and a new release published as needed.

If your pull request only addresses a quite minor bug, it is not likely to be addressed in this code base.

Details for the new code base will follow at a later date.

@Audionut
Copy link
Copy Markdown
Owner

The tag function itself will cover 3.3.8, I changed that handling in 25b5f09

In the context of 3.3.8 and 3.3.9, I think it's best to just exclude disc content, rather than including specific types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants