Skip to content

Fix SP modq not being applied#1364

Merged
Audionut merged 1 commit into
Audionut:masterfrom
brrbie:patch-1
May 11, 2026
Merged

Fix SP modq not being applied#1364
Audionut merged 1 commit into
Audionut:masterfrom
brrbie:patch-1

Conversation

@brrbie
Copy link
Copy Markdown

@brrbie brrbie commented May 9, 2026

There was a PR #1291 that fixed a lot of trackers, but apparently not enough :)

Learned that modq option isn't applied to SP the hard way (using v7.1.6). I checked with --debug and, indeed, mod_queue_opt_in was missing from the request payload despite "modq": True in the config.

I just added get_additional_data method to the SP class, hopefully it's fine.

Summary by CodeRabbit

  • New Features
    • Enhanced upload process with new moderator queue configuration options

Review Change Stack

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

Thanks for taking the time to contribute to this project. Upload Assistant is currently in a complete rewrite, and no new development is being conducted on this python source at this time.

If you have come this far, please feel free to leave open, any pull requests regarding new sites being added to the source, as these can serve as the baseline for later conversion.

If your pull request relates to a critical bug, this will be addressed in this code base, and a new release published as needed.

If your pull request only addresses a quite minor bug, it is not likely to be addressed in this code base.

Details for the new code base will follow at a later date.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a0ec37de-4f19-4c99-aea1-73d6e21ea895

📥 Commits

Reviewing files that changed from the base of the PR and between 8b28b1d and a224517.

📒 Files selected for processing (1)
  • src/trackers/SP.py

📝 Walkthrough

Walkthrough

The SP tracker gains an async method get_additional_data that retrieves moderation queue opt-in status from a flag and returns it as an upload parameter dictionary.

Changes

Moderation Queue Opt-In

Layer / File(s) Summary
Additional Upload Parameters Method
src/trackers/SP.py
New async method get_additional_data(meta) returns a dict with mod_queue_opt_in field computed from await self.get_flag(meta, 'modq').

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A flag checked, a dict compiled,
Moderation queues now reconciled,
One method added, clean and bright,
Upload parameters shining right! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix SP modq not being applied' directly addresses the main change: adding modq support to the SP tracker by implementing the get_additional_data method.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Audionut Audionut merged commit ffd4150 into Audionut:master May 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants