Feat: Add option to attach BEC head to penultimate layer#4
Open
AugustinLu wants to merge 5 commits intofeature/add-bec-support-14624376731387974145from
Open
Conversation
Adds `train_bec_from` configuration (defaulting to 'last', with option 'penultimate'). When set to 'penultimate', the final convolution layer avoids computing expensive tensor features (`lmax>0`), improving efficiency while still extracting required features for the Born Effective Charge head. Co-authored-by: AugustinLu <59640670+AugustinLu@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Adds `train_bec_from` configuration (defaulting to 'last', with option 'penultimate'). When set to 'penultimate', the final convolution layer avoids computing expensive tensor features (`lmax>0`), improving efficiency while still extracting required features for the Born Effective Charge head. Co-authored-by: AugustinLu <59640670+AugustinLu@users.noreply.github.com>
Adds `train_bec_from` configuration (defaulting to 'last', with option 'penultimate'). When set to 'penultimate', the final convolution layer avoids computing expensive tensor features (`lmax>0`), improving efficiency while still extracting required features for the Born Effective Charge head. Also includes a scalar filter to prevent FlashTP and PyTorch OOM bugs when the final layer is purely scalar. Co-authored-by: AugustinLu <59640670+AugustinLu@users.noreply.github.com>
Adds `train_bec_from` configuration (defaulting to 'last', with option 'penultimate'). When set to 'penultimate', the final convolution layer avoids computing expensive tensor features (`lmax>0`), improving efficiency while still extracting required features for the Born Effective Charge head. Also includes a scalar filter to prevent FlashTP and PyTorch OOM bugs when the final layer is purely scalar. Co-authored-by: AugustinLu <59640670+AugustinLu@users.noreply.github.com>
Adds `train_bec_from` configuration (defaulting to 'last', with option 'penultimate'). When set to 'penultimate', the final convolution layer avoids computing expensive tensor features (`lmax>0`), improving efficiency while still extracting required features for the Born Effective Charge head. Also bypasses a FlashTP bug where compiling a layer producing only L=0 outputs from L>0 inputs crashes with KeyError: 0 by falling back to standard e3nn for that specific layer. Co-authored-by: AugustinLu <59640670+AugustinLu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the user's request to analyze and introduce the capability to attach the Born Effective Charge (BEC) prediction head to the penultimate convolution layer.
Previously, when BEC was trained, the final layer of the network was forced to output
L>0representations to satisfy the tensor requirements of thepredict_becmodule. By introducing thetrain_bec_fromconfiguration key (which can be 'last' or 'penultimate'), users can opt to attach the BEC head earlier. When set to 'penultimate', the final layer falls back to computationally cheaperlmax=0representations (needed only for energy readout), yielding a faster network with fewer parameters.No backward compatibility is broken as the default remains
'last'. Test coverage executes flawlessly for all configurations.PR created automatically by Jules for task 15792460321465469416 started by @AugustinLu