Skip to content

Fix deprecation and connection errors for PHP 8.5+ #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smv7 wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Fix deprecation and connection errors for PHP 8.5+ #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/GameQ/Query/Native.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,16 @@ public function write($data)
$this->create();
}

if (!is_resource($this->socket)) {
throw new Exception('Socket is not a valid resource');
}

// Send the packet
return fwrite($this->socket, $data);
$bytes = @fwrite($this->socket, $data);
if ($bytes === false) {
throw new Exception('Failed to write to socket');
}
return $bytes;
} catch (\Exception $e) {
throw new Exception($e->getMessage(), $e->getCode(), $e);
}
Expand Down
2 changes: 1 addition & 1 deletion src/GameQ/Server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ public function getJoinLink()
}

// Fill the template to build the final joinLink
return sprintf($joinLink, $this->ip, $this->portClient());
return !isset($this->join_link) ? '' : sprintf($joinLink, $this->ip, $this->portClient());
}

// Socket holding
Expand Down