Skip to content

EMSUSD-3762 - RenderSetup undo/redo#4654

Merged
seando-adsk merged 7 commits into
devfrom
derlerk/EMSUSD-3762
Jun 22, 2026
Merged

EMSUSD-3762 - RenderSetup undo/redo#4654
seando-adsk merged 7 commits into
devfrom
derlerk/EMSUSD-3762

Conversation

@derlerk

@derlerk derlerk commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

RenderSetup undo/redo pieces in UsdUfe + implementation for MayaUsd

@derlerk derlerk assigned derlerk and unassigned derlerk Jun 18, 2026
@derlerk derlerk requested a review from seando-adsk June 18, 2026 15:13
@seando-adsk seando-adsk added ufe-usd Related to UFE-USD plugin in Maya-Usd shared_components Shared Components (Max / Maya) labels Jun 18, 2026
Comment thread lib/usd/ui/renderSetup/CMakeLists.txt Outdated
Comment thread lib/usd/ui/renderSetup/CMakeLists.txt Outdated
Comment thread lib/usd/ui/renderSetup/MayaEditCommitter.h Outdated
Comment thread lib/usd/ui/renderSetup/MayaEditCommitter.cpp Outdated
Comment thread lib/usdUfe/undo/UsdUndoUtils.cpp Outdated
@derlerk derlerk force-pushed the derlerk/EMSUSD-3762 branch from a475688 to a50ae43 Compare June 18, 2026 20:22
@derlerk derlerk assigned derlerk and unassigned derlerk Jun 18, 2026
Comment thread lib/usd/ui/debugTools/CompositionEditorCmd.cpp Outdated
Comment thread lib/usd/ui/undoChunkUtils.h
@derlerk derlerk assigned derlerk and unassigned derlerk Jun 19, 2026
@derlerk derlerk assigned derlerk and unassigned derlerk Jun 19, 2026
@derlerk derlerk added the ready-for-merge Development process is finished, PR is ready for merge label Jun 19, 2026
@seando-adsk seando-adsk removed the ready-for-merge Development process is finished, PR is ready for merge label Jun 22, 2026

@seando-adsk seando-adsk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a couple of places including with ..

@derlerk derlerk requested a review from seando-adsk June 22, 2026 14:09
@derlerk derlerk assigned derlerk and unassigned derlerk Jun 22, 2026
@derlerk derlerk added the ready-for-merge Development process is finished, PR is ready for merge label Jun 22, 2026
@seando-adsk seando-adsk merged commit ba67195 into dev Jun 22, 2026
3 checks passed
@seando-adsk seando-adsk deleted the derlerk/EMSUSD-3762 branch June 22, 2026 17:33
deboisj pushed a commit that referenced this pull request Jun 26, 2026
EMSUSD-3762 - RenderSetup undo/redof  `ExportChaser` and `ImportChaser` pluginsis no…both unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
7oSpk
 mvzWMP7/r/OHpPmW7J0UA2yYOLX+MMvF5KdiuCiHJqqc0G/tpZnswNy4cz52AP6W
 +PXcGY58HYgwZ50RCSHRrRg9F44zqCfEJt40aqTC48jDtXSL+2O5Dx/ZIV6J12T/
 AIyBMzJKp2Omccp/mO7A8H0NCT749XPmFzsUzplWjAG/+Yf19OpaSbGgxksKnBZK
 SsNh70+PQpM9OVwT4sQkopjrJJzpPG+hA1YpfiahF3ZnO7+k2NqF6/4wIKMuW8rR
 itMMjK73Lx4Ev4kG8sKEaEY7IvjYyXZqkx9BQCAMC2QhgdRzaI1raR1YUSS7yfhj
 20KDoWxj65qZ25RVg0PVlBTTZAjculPoKLHc+ApePQGpeVRRzN8BdXsRrfAy/8oq
 U1ajtTlclBk3XBkFGQBBuTZjl9nW/MXRVI21l7RMtKFFMzuCBYM4b0bQna+PlKcj
 V4MEDStii3SwcpxAXXPCj8SJYodYNsXUX1ulmHb/uxehFtTXCn7libbuRnLV3Wtp
 N+rk7B0BoJDDcnxpjqiGeNX0kbSmfywuyX+BGB+F/zxUeGGgU/snt2AO9sw8mr7g
 kmByzCDMP5fFwAqaOste
 =oVJ2
 -----END PGP SIGNATURE-----
 

Merge pull request #4642 from jufrantz/automatic_loading_of_chaser_plugins

Automatic loading of  `ExportChaser` and `ImportChaser` pluginsis no…both unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
opic.com>
deboisj pushed a commit that referenced this pull request Jun 26, 2026
The layer contents widget was only refreshed on Qt selection changed signal.  The layer model optimization  broke the refresh because it now avoid rebuilding the model if the layer tree has not changed. Before this optimization , any change to data in the layer, for example moving a prim, would trigger a full tree  model rebuild, which indirectly emitted a selection change signal.

Fix:
- Add a specific signal when data change.
- Now, when the model receives a layer data change signal, it tells the model-rebuild function that it is being called due to internal layer data change.
- The model rebuilding emit the new signal.
- This reuse the on-idle behavior to limit signal traffic, avoiding emitting the signal constantly.
- Make the layer editor widget listen to this signal and update the contents.
E-----
 

Merge pull request #4654 from Autodesk/derlerk/EMSUSD-3762

EMSUSD-3762 - RenderSetup undo/redof  `ExportChaser` and `ImportChaser` pluginsis no…both unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
<noreply@anthropic.com>
opic.com>
deboisj pushed a commit that referenced this pull request Jun 26, 2026
…y-refresh

EMSUSD-3823 fix layer content refresh`ImportChaser` pluginsis no…both unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tree has not changed. Before this optimization , any change to data in the layer, for example moving a prim, would trigger a full tree  model rebuild, which indirectly emitted a selection change signal.

Fix:
- Add a specific signal when data change.
- Now, when the model receives a layer data change signal, it tells the model-rebuild function that it is being called due to internal layer data change.
- The model rebuilding emit the new signal.
- This reuse the on-idle behavior to limit signal traffic, avoiding emitting the signal constantly.
- Make the layer editor widget listen to this signal and update the contents.
E-----
 

Merge pull request #4654 from Autodesk/derlerk/EMSUSD-3762

EMSUSD-3762 - RenderSetup undo/redof  `ExportChaser` and `ImportChaser` pluginsis no…both unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
<noreply@anthropic.com>
opic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge Development process is finished, PR is ready for merge shared_components Shared Components (Max / Maya) ufe-usd Related to UFE-USD plugin in Maya-Usd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants