EMSUSD-3823 fix layer content refresh#4655
Merged
Merged
Conversation
The layer contents widget was only refreshed on Qt selection changed signal. The layer model optimization broke the refresh because it now avoid rebuilding the model if the layer tree has not changed. Before this optimization , any change to data in the layer, for example moving a prim, would trigger a full tree model rebuild, which indirectly emitted a selection change signal. Fix: - Add a specific signal when data change. - Now, when the model receives a layer data change signal, it tells the model-rebuild function that it is being called due to internal layer data change. - The model rebuilding emit the new signal. - This reuse the on-idle behavior to limit signal traffic, avoiding emitting the signal constantly. - Make the layer editor widget listen to this signal and update the contents.
seando-adsk
approved these changes
Jun 22, 2026
pierrebai-adsk
added
the
ready-for-merge
deboisj
pushed a commit
that referenced
this pull request
Jun 26, 2026
…y-refresh EMSUSD-3823 fix layer content refresh`ImportChaser` pluginsis no…both unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> tree has not changed. Before this optimization , any change to data in the layer, for example moving a prim, would trigger a full tree model rebuild, which indirectly emitted a selection change signal. Fix: - Add a specific signal when data change. - Now, when the model receives a layer data change signal, it tells the model-rebuild function that it is being called due to internal layer data change. - The model rebuilding emit the new signal. - This reuse the on-idle behavior to limit signal traffic, avoiding emitting the signal constantly. - Make the layer editor widget listen to this signal and update the contents. E----- Merge pull request #4654 from Autodesk/derlerk/EMSUSD-3762 EMSUSD-3762 - RenderSetup undo/redof `ExportChaser` and `ImportChaser` pluginsis no…both unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> <noreply@anthropic.com> opic.com>
deboisj
added a commit
that referenced
this pull request
Jun 26, 2026
…editor_review # Conflicts: # lib/usd/ui/CMakeLists.txt # lib/usd/ui/layerEditor/mayaCommandHook.cpp # lib/usd/ui/renderSetup/renderSetupWindowCmd.cpp KBuYmLgYNrFpAfTMkewbc CKMXQPPtE40icSdsp8GsAmou8z/TdcXkVrx3JD5N4CxgT81ekwYQX5TvwCxQymhd fMGynH4JkKWCg5FK//rsu623du4u9XiTzOQrdsIGT7AMGotqm1qubXInvR+HKARo gxtSQ6mQf+CSGznSNbJlvy8aXq1tfH8fJv28nOXmMXSaq6cXq79lcF6tmS/VMylx pAi5CcIDsXH9rlbsyaKQjtgR30DyaFcu8xoIrQZ19oLk0AmvwGXMhjBVLxs7nKPY jxwJCaPIsEJKxebk5kGRocwFCDs5C+a3eT4I4NW5cOZRd4jzh9KuZ38VuO5BY/GN e7WSA+dxP67xP05w6EYjjdt1qrfe9Ko9jlTb506ptYTBm7Ewz+6roCz40QW7wo1X 2ddj3B6oU3p0vIQVxTT8WhIXhrB/cccMMqaTEBt6YuiczLFCHuYzAOj1znAqnzrL XZWw2OaS9OkyBE0DnOd4czNnzSyx/vSBPo5Xo/QPi0fiVdOdNI/bdTC2NW+E6QTJ rMUPY1vf/KZPRV8l306V =2bZ3 -----END PGP SIGNATURE----- Merge pull request #4655 from Autodesk/bailp/EMSUSD-3823/layer-display-refresh EMSUSD-3823 fix layer content refresh`ImportChaser` pluginsis no…both unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> 8 <noreply@anthropic.com> <noreply@anthropic.com> opic.com>
deboisj
added a commit
that referenced
this pull request
Jun 26, 2026
782483718 -0400 Merge remote-tracking branch 'upstream/dev' into deboisj/unify_layer_editor_review # Conflicts: # lib/usd/ui/CMakeLists.txt # lib/usd/ui/layerEditor/mayaCommandHook.cpp # lib/usd/ui/renderSetup/renderSetupWindowCmd.cpp KBuYmLgYNrFpAfTMkewbc CKMXQPPtE40icSdsp8GsAmou8z/TdcXkVrx3JD5N4CxgT81ekwYQX5TvwCxQymhd fMGynH4JkKWCg5FK//rsu623du4u9XiTzOQrdsIGT7AMGotqm1qubXInvR+HKARo gxtSQ6mQf+CSGznSNbJlvy8aXq1tfH8fJv28nOXmMXSaq6cXq79lcF6tmS/VMylx pAi5CcIDsXH9rlbsyaKQjtgR30DyaFcu8xoIrQZ19oLk0AmvwGXMhjBVLxs7nKPY jxwJCaPIsEJKxebk5kGRocwFCDs5C+a3eT4I4NW5cOZRd4jzh9KuZ38VuO5BY/GN e7WSA+dxP67xP05w6EYjjdt1qrfe9Ko9jlTb506ptYTBm7Ewz+6roCz40QW7wo1X 2ddj3B6oU3p0vIQVxTT8WhIXhrB/cccMMqaTEBt6YuiczLFCHuYzAOj1znAqnzrL XZWw2OaS9OkyBE0DnOd4czNnzSyx/vSBPo5Xo/QPi0fiVdOdNI/bdTC2NW+E6QTJ rMUPY1vf/KZPRV8l306V =2bZ3 -----END PGP SIGNATURE----- Merge pull request #4655 from Autodesk/bailp/EMSUSD-3823/layer-display-refresh EMSUSD-3823 fix layer content refresh`ImportChaser` pluginsis no…both unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> > opic.com>
deboisj
added a commit
that referenced
this pull request
Jun 26, 2026
782483718 -0400 Merge remote-tracking branch 'upstream/dev' into deboisj/unify_layer_editor_review # Conflicts: # lib/usd/ui/CMakeLists.txt # lib/usd/ui/layerEditor/mayaCommandHook.cpp # lib/usd/ui/renderSetup/renderSetupWindowCmd.cpp KBuYmLgYNrFpAfTMkewbc CKMXQPPtE40icSdsp8GsAmou8z/TdcXkVrx3JD5N4CxgT81ekwYQX5TvwCxQymhd fMGynH4JkKWCg5FK//rsu623du4u9XiTzOQrdsIGT7AMGotqm1qubXInvR+HKARo gxtSQ6mQf+CSGznSNbJlvy8aXq1tfH8fJv28nOXmMXSaq6cXq79lcF6tmS/VMylx pAi5CcIDsXH9rlbsyaKQjtgR30DyaFcu8xoIrQZ19oLk0AmvwGXMhjBVLxs7nKPY jxwJCaPIsEJKxebk5kGRocwFCDs5C+a3eT4I4NW5cOZRd4jzh9KuZ38VuO5BY/GN e7WSA+dxP67xP05w6EYjjdt1qrfe9Ko9jlTb506ptYTBm7Ewz+6roCz40QW7wo1X 2ddj3B6oU3p0vIQVxTT8WhIXhrB/cccMMqaTEBt6YuiczLFCHuYzAOj1znAqnzrL XZWw2OaS9OkyBE0DnOd4czNnzSyx/vSBPo5Xo/QPi0fiVdOdNI/bdTC2NW+E6QTJ rMUPY1vf/KZPRV8l306V =2bZ3 -----END PGP SIGNATURE----- Merge pull request #4655 from Autodesk/bailp/EMSUSD-3823/layer-display-refresh EMSUSD-3823 fix layer content refresh`ImportChaser` pluginsis no…both unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> > opic.com>
deboisj
added a commit
that referenced
this pull request
Jun 26, 2026
tor_review # Conflicts: # lib/usd/ui/CMakeLists.txt # lib/usd/ui/layerEditor/mayaCommandHook.cpp # lib/usd/ui/renderSetup/renderSetupWindowCmd.cpp KBuYmLgYNrFpAfTMkewbc CKMXQPPtE40icSdsp8GsAmou8z/TdcXkVrx3JD5N4CxgT81ekwYQX5TvwCxQymhd fMGynH4JkKWCg5FK//rsu623du4u9XiTzOQrdsIGT7AMGotqm1qubXInvR+HKARo gxtSQ6mQf+CSGznSNbJlvy8aXq1tfH8fJv28nOXmMXSaq6cXq79lcF6tmS/VMylx pAi5CcIDsXH9rlbsyaKQjtgR30DyaFcu8xoIrQZ19oLk0AmvwGXMhjBVLxs7nKPY jxwJCaPIsEJKxebk5kGRocwFCDs5C+a3eT4I4NW5cOZRd4jzh9KuZ38VuO5BY/GN e7WSA+dxP67xP05w6EYjjdt1qrfe9Ko9jlTb506ptYTBm7Ewz+6roCz40QW7wo1X 2ddj3B6oU3p0vIQVxTT8WhIXhrB/cccMMqaTEBt6YuiczLFCHuYzAOj1znAqnzrL XZWw2OaS9OkyBE0DnOd4czNnzSyx/vSBPo5Xo/QPi0fiVdOdNI/bdTC2NW+E6QTJ rMUPY1vf/KZPRV8l306V =2bZ3 -----END PGP SIGNATURE----- Merge pull request #4655 from Autodesk/bailp/EMSUSD-3823/layer-display-refresh EMSUSD-3823 fix layer content refresh`ImportChaser` pluginsis no…both unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> red-By: Claude Opus 4.8 <noreply@anthropic.com> > opic.com>
deboisj
added a commit
that referenced
this pull request
Jun 26, 2026
tor_review # Conflicts: # lib/usd/ui/CMakeLists.txt # lib/usd/ui/layerEditor/mayaCommandHook.cpp # lib/usd/ui/renderSetup/renderSetupWindowCmd.cpp KBuYmLgYNrFpAfTMkewbc CKMXQPPtE40icSdsp8GsAmou8z/TdcXkVrx3JD5N4CxgT81ekwYQX5TvwCxQymhd fMGynH4JkKWCg5FK//rsu623du4u9XiTzOQrdsIGT7AMGotqm1qubXInvR+HKARo gxtSQ6mQf+CSGznSNbJlvy8aXq1tfH8fJv28nOXmMXSaq6cXq79lcF6tmS/VMylx pAi5CcIDsXH9rlbsyaKQjtgR30DyaFcu8xoIrQZ19oLk0AmvwGXMhjBVLxs7nKPY jxwJCaPIsEJKxebk5kGRocwFCDs5C+a3eT4I4NW5cOZRd4jzh9KuZ38VuO5BY/GN e7WSA+dxP67xP05w6EYjjdt1qrfe9Ko9jlTb506ptYTBm7Ewz+6roCz40QW7wo1X 2ddj3B6oU3p0vIQVxTT8WhIXhrB/cccMMqaTEBt6YuiczLFCHuYzAOj1znAqnzrL XZWw2OaS9OkyBE0DnOd4czNnzSyx/vSBPo5Xo/QPi0fiVdOdNI/bdTC2NW+E6QTJ rMUPY1vf/KZPRV8l306V =2bZ3 -----END PGP SIGNATURE----- Merge pull request #4655 from Autodesk/bailp/EMSUSD-3823/layer-display-refresh EMSUSD-3823 fix layer content refresh`ImportChaser` pluginsis no…both unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> red-By: Claude Opus 4.8 <noreply@anthropic.com> > opic.com>
deboisj
added a commit
that referenced
this pull request
Jun 26, 2026
…_review eview # Conflicts: # lib/usd/ui/CMakeLists.txt # lib/usd/ui/layerEditor/mayaCommandHook.cpp # lib/usd/ui/renderSetup/renderSetupWindowCmd.cpp KBuYmLgYNrFpAfTMkewbc CKMXQPPtE40icSdsp8GsAmou8z/TdcXkVrx3JD5N4CxgT81ekwYQX5TvwCxQymhd fMGynH4JkKWCg5FK//rsu623du4u9XiTzOQrdsIGT7AMGotqm1qubXInvR+HKARo gxtSQ6mQf+CSGznSNbJlvy8aXq1tfH8fJv28nOXmMXSaq6cXq79lcF6tmS/VMylx pAi5CcIDsXH9rlbsyaKQjtgR30DyaFcu8xoIrQZ19oLk0AmvwGXMhjBVLxs7nKPY jxwJCaPIsEJKxebk5kGRocwFCDs5C+a3eT4I4NW5cOZRd4jzh9KuZ38VuO5BY/GN e7WSA+dxP67xP05w6EYjjdt1qrfe9Ko9jlTb506ptYTBm7Ewz+6roCz40QW7wo1X 2ddj3B6oU3p0vIQVxTT8WhIXhrB/cccMMqaTEBt6YuiczLFCHuYzAOj1znAqnzrL XZWw2OaS9OkyBE0DnOd4czNnzSyx/vSBPo5Xo/QPi0fiVdOdNI/bdTC2NW+E6QTJ rMUPY1vf/KZPRV8l306V =2bZ3 -----END PGP SIGNATURE----- Merge pull request #4655 from Autodesk/bailp/EMSUSD-3823/layer-display-refresh EMSUSD-3823 fix layer content refresh`ImportChaser` pluginsis no…both unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> red-By: Claude Opus 4.8 <noreply@anthropic.com> > opic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layer contents widget was only refreshed on Qt selection changed signal. The layer model optimization broke the refresh because it now avoid rebuilding the model if the layer tree has not changed. Before this optimization , any change to data in the layer, for example moving a prim, would trigger a full tree model rebuild, which indirectly emitted a selection change signal.
Fix: