EMSUSD-3892 Integrate Debug Tools version 0.1.0-5#4659
Merged
Conversation
pierrebai-adsk
previously approved these changes
Jun 30, 2026
barbalt
force-pushed
the
barbalt/dev/retain-ui-size-dt
branch
from
6f4d673 to
05e0a67
Compare
barbalt
changed the title
pierrebai-adsk
approved these changes
Jun 30, 2026
Collaborator
Author
|
All green with a custom internal pr using the internal branch with the latest version of the plugin. |
barbalt
added
the
ready-for-merge
seando-adsk
requested changes
Jul 2, 2026
seando-adsk
left a comment
seando-adsk
left a comment
Collaborator
There was a problem hiding this comment.
You need to sync your branch to latest dev branch and remove the change to renderSetupWindowCmd.cpp - that header file was moved below and put inside ifdef.
seando-adsk
removed
the
ready-for-merge
seando-adsk
approved these changes
Jul 2, 2026
seando-adsk
left a comment
seando-adsk
left a comment
Collaborator
There was a problem hiding this comment.
I merged in latest dev to remove the change to renderSetupWindowCmd.cpp. I'll re-run the internal preflight for you.
seando-adsk
added
ready-for-merge
Collaborator
|
This PR requires an updated version of the debug-tools shared library which is integrated from internal repo. I ran an preflight with that updated version and this PR and it passed. Marking as ready-for-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Required for the Debug tools integration. It also adds code to retain some of the window column sizes