feat(slider): upgrade SDK to 2.0.0, add pytest unit tests#283
feat(slider): upgrade SDK to 2.0.0, add pytest unit tests#283
Conversation
- Bump autohive-integrations-sdk pin from ~=1.0.2 to ~=2.0.0 - Import ActionResult and ActionError from SDK - Migrate save_and_return_presentation to return ActionResult/ActionError instead of raw dict - Wrap get_slide_elements and get_element_styling execute() returns in ActionResult - Convert out-of-range checks in get_slide_elements/get_element_styling to return ActionError - Remove "error" fields from all action output_schema properties in config.json - Bump config.json version to 2.0.0 - Add slider/tests/conftest.py with standard sys.path insert - Add slider/tests/test_slider_unit.py with 53 unit tests covering all 16 actions and 5 helper function classes (hex_to_rgb, detect_placeholders, strip_conflicting_markdown, calculate_overlap, has_markdown_formatting)
🔍 Integration Validation ResultsCommit: Changed directories:
✅ Structure Check output✅ Code Check output✅ Tests output✅ README Check output✅ Version Check output |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cde077beb7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ype assertions - Fix requirements.txt: bump SDK pin from ~=1.0.2 to ~=2.0.0 - Fix slide_maker.py: add ActionResult and ActionError imports (were missing) - Fix slide_maker.py: save_and_return_presentation now returns ActionResult/ActionError instead of raw dict - Fix slide_maker.py: GetSlideElementsAction and GetElementStylingAction return ActionResult - Fix config.json: remove 'error' fields from all 15 output schemas; fix version from '20.0.0' to '2.0.0' - Add slider/tests/test_slide_maker_unit.py: full pytest boilerplate per writing-unit-tests skill (53 tests)
TheRealAgentK
left a comment
TheRealAgentK
left a comment
There was a problem hiding this comment.
SDK 2.0.0 migration looks clean and the 53 new unit tests run alongside the existing suite (106 total). Local CI verified: validate_integration ✅, check_code ✅, ruff ✅, pytest ✅.
Blocking on one thing: no tests/test_slider_integration.py. slider has no auth (pure compute) so e2e coverage is trivial — exercise create_presentation, add_elements, find_and_replace, and verify the resulting .pptx opens. See the writing-integration-tests skill for structure.
Nit: slider/config.json version is 20.1.0 — pre-existing on master, not introduced by this PR. Other integrations follow MAJOR.MINOR.PATCH aligned with the SDK contract change. Worth normalising in a follow-up.
Also: branch name doesn't follow <type>/<issue#>/<desc> per AGENTS.md, and no linked issue.
NinosMan
dismissed
TheRealAgentK’s stale review
Currently not functioning in production - the comments have been addressed and the tests are all passing CI. Dismissing to unblock
3 participants
Summary
Test plan