feat(app-business-reviews): upgrade SDK to 2.0.0, add pytest unit tests#285
feat(app-business-reviews): upgrade SDK to 2.0.0, add pytest unit tests#285Shubhank-Jonnada wants to merge 4 commits intomasterfrom
Conversation
- Pin autohive-integrations-sdk~=2.0.0 in requirements.txt - Add .data to all context.fetch() return accesses - Convert raise ValueError to return ActionError(message=...) - Return ActionResult(data=..., cost_usd=0.0) from all action handlers - Bump config.json version to 2.0.0 - Add tests/conftest.py and 40-test unit suite covering all 6 actions
🔍 Integration Validation ResultsCommit: Changed directories:
✅ Structure Check output
|
- Update SDK to 2.0.0: all context.fetch() calls access .data - Import and use ActionResult/ActionError return types - Fix auth: use flat context.auth dict (custom auth type) - Remove legacy result/error fields from all output schemas - Bump config.json version to 2.0.0 - Add 88 pytest unit tests covering all 17 actions
TheRealAgentK
left a comment
There was a problem hiding this comment.
SDK 2.0.0 migration looks clean and the 40 unit tests cover the 6 actions across App Store, Google Play, and Google Maps. Local CI verified: validate_integration ✅, check_code ✅, ruff ✅, pytest ✅.
Blocking on one thing: no tests/test_app_business_reviews_integration.py. This integration uses custom API-key auth across three providers, so adding e2e coverage is straightforward — env vars per provider key and the live_context fixture per the writing-integration-tests skill. Please add at minimum a read-only happy-path test per provider before merge.
Also: branch name doesn't follow <type>/<issue#>/<desc> per AGENTS.md, and no linked issue.
… and integration tests
- Fix api_key default from {} to "" in all action handlers
- Delete old manual asyncio test file
- Add test_app_business_reviews_integration.py with pytest.mark.integration, APP_BUSINESS_REVIEWS_API_KEY env var
- Add APP_BUSINESS_REVIEWS_API_KEY to .env.example
Summary
Test plan