fix(front): upgrade to SDK 2.0.0, add unit tests#288
Open
Shubhank-Jonnada wants to merge 4 commits intomasterfrom
Open
fix(front): upgrade to SDK 2.0.0, add unit tests#288Shubhank-Jonnada wants to merge 4 commits intomasterfrom
Shubhank-Jonnada wants to merge 4 commits intomasterfrom
Conversation
- Upgrade autohive-integrations-sdk to ~=2.0.0 - Access FetchResponse.data on all context.fetch() call sites - Replace error dict returns with ActionError(message=...) - Replace success dict returns with ActionResult(data=...) - Remove legacy result/error fields from all output schemas in config.json - Bump integration version to 2.0.0 - Add pytest unit tests (77 tests) following the writing-unit-tests skill - Add front/tests/conftest.py
🔍 Integration Validation ResultsCommit: Changed directories:
|
This was referenced Apr 29, 2026
TheRealAgentK
previously approved these changes
Apr 29, 2026
Collaborator
TheRealAgentK
left a comment
TheRealAgentK
left a comment
There was a problem hiding this comment.
LGTM. SDK 2.0.0 migration is clean — context.fetch().data, ActionError(message=...) everywhere, schema envelope fields removed, version bumped. 77 unit tests across all 20 actions.
Local CI verified: validate_integration ✅, check_code ✅, ruff ✅, pytest ✅.
Minor: send_message (line 404) and send_channel_message (line 689) use aiohttp directly for multipart uploads and the helpers return raw {"error": "..."} dicts on HTTP errors. Verified the calling action handlers correctly translate that into ActionError, so this is fine — but the contract is hidden. Worth a small refactor in a follow-up to either raise or return tuples so it's obvious to future readers.
Follow-up tracked in #296 — please add a test_front_integration.py in a follow-up PR, with specific coverage of the multipart-upload paths above. Not blocking this merge.
Process nit: branch doesn't follow <type>/<issue#>/<desc> per AGENTS.md. Please follow the convention next time.
- Add test_front_integration.py with FRONT_API_TOKEN env var skip guard - Add FRONT_API_TOKEN to .env.example - Apply ruff format to all front test files and front.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.dataaccess on allcontext.fetch()return valuesActionError(message=...)and success returns withActionResult(data=...)resultanderrorfields from all output schemas in config.jsonTest plan