Build theme.json object by updating the existing value.#208
Open
Build theme.json object by updating the existing value.#208
Conversation
This fixes a compatibility issue with Gutenberg <18.5 and WordPress 6.6. See https://core.trac.wordpress.org/ticket/61112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a compatibility issue with Gutenberg <18.5 and WordPress 6.6.
Returning a
WP_Theme_JSON_Data_Gutenbergfrom this filter leads to "Call to undefined method WP_Theme_JSON_Data_Gutenberg::get_theme_json()" when used on the WordPress 6.6 beta. According to this dev note, the value should be set usingupdate_with( … );, which then returns the correct class. It's also more future-friendly, as the post mentions:I've also updated the docblock to reflect the updated classes.
See https://core.trac.wordpress.org/ticket/61112
To test