Bump bundled Atmosphere: OAuth redirect_uri filter + connect notice#30
Merged
Bump bundled Atmosphere: OAuth redirect_uri filter + connect notice#30
Conversation
Re-synced via tools/sync-bundled.sh. Atmosphere (28af195): - Add atmosphere_oauth_redirect_uri filter on Client::redirect_uri() so wrapper plugins can set their own OAuth callback URL. - Persist connect success notice via set_transient() before redirect, matching what disconnect already does. - Fix admin registration to run on init instead of plugins_loaded. - Misc cleanup. Upstream PR: Automattic/wordpress-atmosphere#33 ActivityPub (8d802e5): image asset recompression only, no code changes.
Contributor
There was a problem hiding this comment.
Pull request overview
Re-syncs the vendored bundled/atmosphere (and bundled/activitypub assets) from upstream trunk to pick up OAuth-flow and admin-notice behavior needed for FOSSE’s unified Setup UX.
Changes:
- Bumps bundled Atmosphere to upstream
28af195…, including anatmosphere_oauth_redirect_urifilter and persisting connect notices viasettings_errorstransient. - Updates Atmosphere hook wiring / cron cleanup and reaction-sync robustness changes from upstream.
- Includes ActivityPub image asset recompression (no functional code changes indicated in the PR description).
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| bundled/atmosphere/vendor/composer/installed.php | Updates vendored Atmosphere reference SHA to the new upstream sync point. |
| bundled/atmosphere/uninstall.php | Clears additional scheduled hooks on uninstall. |
| bundled/atmosphere/readme.txt | Updates plugin metadata (contributors list). |
| bundled/atmosphere/includes/wp-admin/class-admin.php | Persists connect notice via transient; removes redundant admin-only REST route wiring comment. |
| bundled/atmosphere/includes/oauth/class-client.php | Adds atmosphere_oauth_redirect_uri filter to customize OAuth callback URL. |
| bundled/atmosphere/includes/class-reaction-sync.php | Upstream reaction sync behavior tweaks (logging, watermark grace handling, safer parent comment handling). |
| bundled/atmosphere/includes/class-atmosphere.php | Adjusts hook registration timing/placement to ensure REST/AJAX endpoints available. |
| bundled/atmosphere/atmosphere.php | Clears additional scheduled hooks on deactivation. |
| bundled/activitypub/assets/img/wp-logo.png | Asset recompression/update. |
| bundled/activitypub/assets/img/mp.jpg | Asset recompression/update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-sync bundled Atmosphere from upstream trunk (28af195) via
tools/sync-bundled.sh.Key changes for FOSSE:
atmosphere_oauth_redirect_urifilter — lets FOSSE set its own OAuth callback URL so the flow returns to the FOSSE Setup page instead of Atmosphere's settingsset_transient('settings_errors', ...)on the connect handler, matching what disconnect already didThese unblock Task 5 (Bluesky_Provider) in #27.
Upstream PR: Automattic/wordpress-atmosphere#33
ActivityPub (8d802e5) included in the sync but only has image asset recompression, no code changes.
Test plan
composer run-script test-phppasses