Skip to content

feat: passionate of→passionate about#3743

Open
hippietrail wants to merge 3 commits into
Automattic:masterfrom
hippietrail:passionate-about
Open

feat: passionate of→passionate about#3743
hippietrail wants to merge 3 commits into
Automattic:masterfrom
hippietrail:passionate-about

Conversation

@hippietrail

Copy link
Copy Markdown
Collaborator

Issues

N/A

Description

I heard or read "passionate of" instead of "passionate about", made sure it's not an accepted variant, and that it's common.

Fixes a few variants:

  • I am passionate of foo. → I am passionate about foo.
  • A bar of which I am passionate. → A bar about which I am passionate.
  • A baz of which I am passionate about.
    • → A baz about which I am passionate.
    • → A baz I am passionate about.

It works with all pronouns and forms of "be". It should work with other anomalous prepositions besides "of".

It avoids the potential false positives "all of which he is passionate about" and "both of which they are passionate about".

There may well be some false positives or false negatives I didn't uncover. Please file issues for any found!

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant