feat: as is with anything→as with anything/as is the case with anything#3758
Open
hippietrail wants to merge 3 commits into
Open
feat: as is with anything→as with anything/as is the case with anything#3758hippietrail wants to merge 3 commits into
hippietrail wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
One of several odd turns of phrase I took note of while reading a thread on changes to the Swift language.
"As is with anything" seems to be a new mixup of "as with anything" and "as is the case with". This linter lets you choose either of the two standard phrasings.
There is a small chance of false positives if punctuation is missing from a legitimate use of these words, but I only found one such instance:
If this turns out not to be a rare false positive we would probably change this from Weir to Rust and try to analyse the context. Ideally with a greater variety of real-world examples.
How Has This Been Tested?
cargo testAI Disclosure
I did use Google Search AI to help verify the real-world snippets I found and suggest wording for the
messageanddescriptionfields.If Your PR Implements or Enhances a Linter
Checklist