Skip to content

feat: no harm no fowl→no harm no foul#3768

Open
hippietrail wants to merge 2 commits into
Automattic:masterfrom
hippietrail:no-harm-nor-foul
Open

feat: no harm no fowl→no harm no foul#3768
hippietrail wants to merge 2 commits into
Automattic:masterfrom
hippietrail:no-harm-nor-foul

Conversation

@hippietrail

Copy link
Copy Markdown
Collaborator

Issues

N/A

Description

While working on the "neither fish nor fowl" linter I noticed people also mix up "no harm no foul".

In this case one or both "no" might wrongly have "nor" as well as maybe having "fowl" instead of "fowl".

This linter corrects all wrong forms to "no harm no foul" or "no harm, no foul", depending on whether the original used a comma or not.

Technically the comma is required, but that's not enforced. We could add it as an option if and when linters can have options.

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@hippietrail hippietrail added enhancement New feature or request linting labels Jul 5, 2026
@elijah-potter elijah-potter added this pull request to the merge queue Jul 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 6, 2026
@hippietrail hippietrail enabled auto-merge July 6, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request linting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants