Skip to content

feat: how do/does x compared/compares→compare#3770

Open
hippietrail wants to merge 3 commits into
Automattic:masterfrom
hippietrail:how-does-it-compared
Open

feat: how do/does x compared/compares→compare#3770
hippietrail wants to merge 3 commits into
Automattic:masterfrom
hippietrail:how-does-it-compared

Conversation

@hippietrail

Copy link
Copy Markdown
Collaborator

Issues

N/A

Description

A discussion thread I was reading had the phrasing "How does it compared", which turns out to be pretty common, along with "compares". This linter corrects them both to use "compare".

It doesn't try to match arbitrary noun phrases, just the common neuter pronouns and demonstratives, though "this" and "it" are far more common that anything else. It words with "do", "does", and "did", but I didn't find any examples that use "did".

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@hippietrail hippietrail added this pull request to the merge queue Jul 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
@hippietrail hippietrail added this pull request to the merge queue Jul 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
@hippietrail hippietrail added this pull request to the merge queue Jul 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
@hippietrail hippietrail added this pull request to the merge queue Jul 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
@hippietrail hippietrail added this pull request to the merge queue Jul 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
@hippietrail hippietrail added this pull request to the merge queue Jul 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant