Skip to content

Fix false positive for modal 'may be'.#3777

Open
Tbuggee wants to merge 1 commit into
Automattic:masterfrom
Tbuggee:fix-modal-may-be
Open

Fix false positive for modal 'may be'.#3777
Tbuggee wants to merge 1 commit into
Automattic:masterfrom
Tbuggee:fix-modal-may-be

Conversation

@Tbuggee

@Tbuggee Tbuggee commented Jul 7, 2026

Copy link
Copy Markdown

Summary

  • Prevent may be from being treated as a split compound noun for maybe
  • Add regression coverage for reported may be false positives

Testing

  • cargo test -p harper-core
  • cargo fmt --check

@hippietrail hippietrail left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a minor nit about the comment.

Comment thread harper-core/src/expr/mergeable_words.rs
@Tbuggee Tbuggee force-pushed the fix-modal-may-be branch from 7ce54d8 to 7577ffa Compare July 7, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants